Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reddit social icon to latest brand guidelines #59438

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Sam-Xronn
Copy link
Contributor

Fixes #59088

Updated Reddit icon to match latest brand guidelines;
https://reddit.lingoapp.com/s/d9x3n2/?v=21

@Sam-Xronn Sam-Xronn requested a review from ajitbohra as a code owner February 28, 2024 13:55
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Sam-Xronn, @AnukratiMehta.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: Sam-Xronn, AnukratiMehta.

Co-authored-by: colinduwe <[email protected]>
Co-authored-by: hanneslsm <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Sam-Xronn! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 28, 2024
@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Block] Social Affects the Social Block - used to display Social Media accounts labels Mar 12, 2024
@t-hamano t-hamano self-requested a review March 12, 2024 13:08
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sam-Xronn,

I think this PR is completely correct. Looking at the new guidelines, there are no changes to the brand color, so all we need to do is update the svg data.

Thank you for your first contribution!

Before

before

After

after

@t-hamano t-hamano merged commit f6531c3 into WordPress:trunk Mar 12, 2024
60 of 62 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 12, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
Unlinked contributors: Sam-Xronn, AnukratiMehta.

Co-authored-by: colinduwe <[email protected]>
Co-authored-by: hanneslsm <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social Icons: Update Reddit Logo
2 participants